Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csharpier from 0.26.5 to 0.26.7 #200

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps csharpier from 0.26.5 to 0.26.7.

Release notes

Sourced from csharpier's releases.

0.26.7

What's Changed

Keep Field.Method() on the same line when breaking long method chain #1010

0.26.0 introduced changes that broke long invocation chains on fields/properties as well as methods. That change has been reverted after community feedback.

// 0.26.0
var loggerConfiguration = new LoggerConfiguration()
    .Enrich
    .FromLogContext()
    .Enrich
    .WithProperty("key", "value")
    .Enrich
    .WithProperty("key", "value")
    .Enrich
    .WithProperty("key", "value")
    .Enrich
    .WithProperty("key", "value")
    .WriteTo
    .Console(outputTemplate: "template");
// 0.26.7
var loggerConfiguration = new LoggerConfiguration()
.Enrich.FromLogContext()
.Enrich.WithProperty("key", "value")
.Enrich.WithProperty("key", "value")
.Enrich.WithProperty("key", "value")
.Enrich.WithProperty("key", "value")
.WriteTo.Console(outputTemplate: "template");

Full Changelog: belav/csharpier@0.26.6...0.26.7

0.26.6

What's Changed

CSharpier incorrectly reports problems with differing line endings as "The file did not end with a single newline"#1067

If CSharpier was validating that a file was formatted, and that file contained only \n but CSharpier was configured to use \r\n, then it would report the problem as The file did not end with a single newline

CSharpier added support for reading line ending configuration from an .editorconfig which could contain end_of_line = crlf so some users were unknowingly configuring CSharpier to use \r\n

CSharpier now correctly reports the problem as The file contained different line endings than formatting it would result in.

Full Changelog: belav/csharpier@0.26.5...0.26.6

Changelog

Sourced from csharpier's changelog.

# 0.26.7

What's Changed

Keep Field.Method() on the same line when breaking long method chain #1010

0.26.0 introduced changes that broke long invocation chains on fields/properties as well as methods. That change has been reverted after community feedback.

// 0.26.0
var loggerConfiguration = new LoggerConfiguration()
    .Enrich
    .FromLogContext()
    .Enrich
    .WithProperty("key", "value")
    .Enrich
    .WithProperty("key", "value")
    .Enrich
    .WithProperty("key", "value")
    .Enrich
    .WithProperty("key", "value")
    .WriteTo
    .Console(outputTemplate: "template");
// 0.26.7
var loggerConfiguration = new LoggerConfiguration()
.Enrich.FromLogContext()
.Enrich.WithProperty("key", "value")
.Enrich.WithProperty("key", "value")
.Enrich.WithProperty("key", "value")
.Enrich.WithProperty("key", "value")
.WriteTo.Console(outputTemplate: "template");

Full Changelog: belav/csharpier@0.26.6...0.26.7

0.26.6

What's Changed

CSharpier incorrectly reports problems with differing line endings as "The file did not end with a single newline"#1067

If CSharpier was validating that a file was formatted, and that file contained only \n but CSharpier was configured to use \r\n, then it would report the problem as The file did not end with a single newline

CSharpier added support for reading line ending configuration from an .editorconfig which could contain end_of_line = crlf so some users were unknowingly configuring CSharpier to use \r\n

CSharpier now correctly reports the problem as The file contained different line endings than formatting it would result in.

Full Changelog: belav/csharpier@0.26.5...0.26.6

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [csharpier](https://github.com/belav/csharpier) from 0.26.5 to 0.26.7.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.26.5...0.26.7)

---
updated-dependencies:
- dependency-name: csharpier
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file nuget Refers to nuget packages packages Packages labels Dec 18, 2023
@dependabot dependabot bot requested a review from guibranco December 18, 2023 01:34
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
Copy link
Owner

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@guibranco guibranco enabled auto-merge (squash) December 18, 2023 01:35
@guibranco
Copy link
Owner

@dependabot squash and merge

Copy link
Contributor

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (77a83bd) 1778 4 0.22%
Head commit (8c8f7a4) 1778 (+0) 4 (+0) 0.22% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#200) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@AppVeyorBot
Copy link

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77a83bd) 0.22% compared to head (4206df7) 0.22%.
Report is 2 commits behind head on main.

❗ Current head 4206df7 differs from pull request most recent head 66f2379. Consider uploading reports for the commit 66f2379 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #200   +/-   ##
=====================================
  Coverage   0.22%   0.22%           
=====================================
  Files        117     117           
  Lines       1778    1778           
  Branches      75      75           
=====================================
  Hits           4       4           
+ Misses      1774    1772    -2     
- Partials       0       2    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 18, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Qodana for .NET

1 new problem were found

Inspection name Severity Problems
Possible 'System.NullReferenceException' 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@guibranco
Copy link
Owner

@gstraccini cshapier

Copy link
Contributor

gstraccini bot commented Dec 18, 2023

I'm sorry @guibranco, I can't do that. 🥺

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c51e24) 1778 4 0.22%
Head commit (4206df7) 1778 (+0) 4 (+0) 0.22% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#200) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@AppVeyorBot
Copy link

@guibranco
Copy link
Owner

@gstraccini csharpier

Copy link
Contributor

gstraccini bot commented Dec 18, 2023

Running CSharpier on this branch! 🔧

Copy link
Contributor

gstraccini bot commented Dec 18, 2023

CSharpier result:

Error ./Src/VTEX/VTEXWrapper.cs - Was not formatted.
  ----------------------------- Expected: Around Line 81 -----------------------------
                  var assembly = System
                      .Reflection.Assembly.GetAssembly(typeof(VTEXWrapper))
                      .GetName();
  ----------------------------- Actual: Around Line 81 -----------------------------
                  var assembly = System
                      .Reflection
                      .Assembly
  
Error ./Src/VTEX/VTEXContext.cs - Was not formatted.
  ----------------------------- Expected: Around Line 267 -----------------------------
                      transaction.TransactionId != null
                      && !transaction.TransactionId.Equals(
                          @"NO-PAYMENT",
  ----------------------------- Actual: Around Line 267 -----------------------------
                      transaction.TransactionId != null
                      && !transaction
                          .TransactionId
  
Error ./Tests/VTEX.Tests/Health/VtexHealthClientTests.cs - Was not formatted.
  ----------------------------- Expected: Around Line 60 -----------------------------
              var result = await clientMock
                  .Object.GetPlatformStatuesAsync(CancellationToken.None)
                  .ConfigureAwait(false);
  ----------------------------- Actual: Around Line 60 -----------------------------
              var result = await clientMock
                  .Object
                  .GetPlatformStatuesAsync(CancellationToken.None)
  

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AppVeyorBot
Copy link

Build VTEX-SDK-dotnet 2.3.534 completed (commit ee5d772557 by @)

@guibranco guibranco merged commit e895fe8 into main Dec 18, 2023
17 of 19 checks passed
@guibranco guibranco deleted the dependabot/nuget/csharpier-0.26.7 branch December 18, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code nuget Refers to nuget packages packages Packages size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants